Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aspellDicts: force grep to treat dictionaries as text files #101194

Merged
merged 1 commit into from Oct 23, 2020
Merged

aspellDicts: force grep to treat dictionaries as text files #101194

merged 1 commit into from Oct 23, 2020

Conversation

acowley
Copy link
Contributor

@acowley acowley commented Oct 20, 2020

Fixes #101184

Motivation for this change

The aspell science dictionary stopped building as the grep processing of the dictionary failed due to the file being recognized as a binary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cole-h
cole-h approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. Had to comment out aspellDicts.en-science in my home config, so hopefully this gets merged soon and makes it into a nixos-unstable bump!

[10 built, 161 copied (1868.3 MiB), 592.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/101194
4 packages built:
aspellDicts.en-computers aspellDicts.en-science paperwork retext

@samueldr samueldr merged commit a2f9d7c into NixOS:master Oct 23, 2020
@acowley acowley deleted the aspellDicts branch October 23, 2020 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aspellDicts.en-science doesn't build
3 participants
@acowley @cole-h @samueldr