Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luxcorerender: fix compilation #101195

Closed
wants to merge 1 commit into from
Closed

luxcorerender: fix compilation #101195

wants to merge 1 commit into from

Conversation

jmpunkt
Copy link
Contributor

@jmpunkt jmpunkt commented Oct 20, 2020

Nix overwrites the include path for the OpenCL headers. However, the
overwrite does not include the required headers. The compilation fails
due to missing header files (<CL/cl.hpp>). Removing the overwrite
allows CMake to find the required headers.

Motivation for this change

Luxcorerender currently can not be build from master and fails on Hydra 20.09. Should be backported after being merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jmpunkt
luxcorerender: fix compilation
ba438f9 
Nix overwrites the include path for the OpenCL headers. However, the
overwrite does not include the required headers. The compilation fails
due to missing header files (<CL/cl.hpp>). Removing the overwrite
allows CMake to find the required headers.
@ofborg ofborg bot requested a review from Hodapp87 October 20, 2020 17:46
@jmpunkt
Copy link
Contributor Author

jmpunkt commented Oct 20, 2020

Does not fix the problem. CMake silently disables OpenCL (prints an error message but does not fail). Looking further into this and create a new PR if the problem is solved.

@jmpunkt jmpunkt closed this Oct 20, 2020
@jmpunkt jmpunkt deleted the luxcorerender-fix-compilation branch November 13, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hodapp87 Hodapp87 Hodapp87 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmpunkt @Hodapp87