Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ngscopeclient/scopehal-apps
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 628cbf600822
Choose a base ref
...
head repository: ngscopeclient/scopehal-apps
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fba30981bf98
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Oct 21, 2020

  1. Copy the full SHA
    fba3098 View commit details
Showing with 7 additions and 2 deletions.
  1. +1 −1 lib
  2. +6 −1 src/glscopeclient/FilterDialog.cpp
2 changes: 1 addition & 1 deletion lib
7 changes: 6 additions & 1 deletion src/glscopeclient/FilterDialog.cpp
Original file line number Diff line number Diff line change
@@ -98,7 +98,10 @@ void ParameterRowFilename::OnClear()

void ParameterRowFilename::OnBrowser()
{
Gtk::FileChooserDialog dlg(*m_parent, "Open", Gtk::FILE_CHOOSER_ACTION_OPEN);
Gtk::FileChooserDialog dlg(
*m_parent,
m_param.m_fileIsOutput ? "Save" : "Open",
m_param.m_fileIsOutput ? Gtk::FILE_CHOOSER_ACTION_SAVE : Gtk::FILE_CHOOSER_ACTION_OPEN);
dlg.set_filename(m_entry.get_text());

auto filter = Gtk::FileFilter::create();
@@ -107,6 +110,8 @@ void ParameterRowFilename::OnBrowser()
dlg.add_filter(filter);
dlg.add_button("Open", Gtk::RESPONSE_OK);
dlg.add_button("Cancel", Gtk::RESPONSE_CANCEL);
if(m_param.m_fileIsOutput)
dlg.set_do_overwrite_confirmation();;
auto response = dlg.run();

if(response != Gtk::RESPONSE_OK)