Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtapi: fix build for linux #101226

Merged
merged 1 commit into from Oct 29, 2020
Merged

libtapi: fix build for linux #101226

merged 1 commit into from Oct 29, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 21, 2020 •
edited

Motivation for this change

noticed when reviewing #101215

/nix/store/ajq5dfwn4hzlx1qf2xxwb6rj8a7s65nm-stdenv-linux/setup: line 81: install_name_tool: command not found
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 21, 2020
@thefloweringash
Copy link
Member

This package should be able to build on linux as well as darwin. Since the failure is in postInstall, it probably did build. Can we make the postInstall step conditional instead?

@jonringer jonringer changed the title libtapi: mark as darwin only libtapi: fix build for linux Oct 21, 2020
@jonringer jonringer changed the base branch from master to staging October 27, 2020 00:22
@jonringer
Copy link
Contributor Author

wow! was able to do do a master -> staging rebase without pinging all the CODEOWNERS 👍

@jonringer
Copy link
Contributor Author

This shouldn't have changed anything for darwin. But I guess that's why staging exists.

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build darwin.libtapi

@jonringer
Copy link
Contributor Author

looks like I forgot the original PR had more than one commit.

@jonringer jonringer merged commit 16357a6 into NixOS:staging Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @thefloweringash