Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] mopidy-local: init at 3.1.1 #101197

Merged
merged 3 commits into from Oct 21, 2020

Conversation

ruuda
Copy link
Contributor

@ruuda ruuda commented Oct 20, 2020

Motivation for this change

@mweinelt mentioned:

As the mopidy-local-{sqlite,images} packages are broken on 20.09 I think this is worth backporting to release-20.09.

This is a backport of #93400.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I also tested compiling a buildEnv with mopidy-local and mopidy-iris and running the resulting mopidy binary.

Mopidy-Local is the successor to Mopidy-Local-SQLite and
Mopidy-Local-Images, which are already packaged. I had to make
gobject-introspection a propagated build input, otherwise
Mopidy-Local can't import Mopidy.

Backporting because mopidy-local-sqlite and mopidy-local-images are
broken in 20.09 without this change and the subsequent removals.

(cherry picked from commit 7565d00)
This plugin has been merged into the newer "mopidy-local" plugin which I
just added. "mopidy-local-images" and "mopidy-local-sqlite" were added
originally for Mopidy Iris, but Iris now works with mopidy-local, and
does not need the older plugins any more.

Backporting because mopidy-local-images is broken in 20.09.

(cherry picked from commit 79a823c)
This plugin has been merged into the newer "mopidy-local" plugin which I
just added. "mopidy-local-images" and "mopidy-local-sqlite" were added
originally for Mopidy Iris, but Iris now works with mopidy-local, and
does not need the older ones any more.

Backporting because mopidy-local-sqlite is broken in 20.09.

(cherry picked from commit b82ca4d)
@ruuda
Copy link
Contributor Author

ruuda commented Oct 20, 2020

Pinging @NixOS/nixos-release-managers as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants