Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging next #101207

Merged
merged 22 commits into from Nov 4, 2020
Merged

Staging next #101207

merged 22 commits into from Nov 4, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Oct 20, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@TredwellGit
Copy link
Member

#101199 apparently breaks Ghostscript. Currently working on a fix along with updating Ghostscript and jbig2dec.

@TredwellGit TredwellGit mentioned this pull request Oct 20, 2020
Merged
3 tasks
@FRidh FRidh requested a review from zowoq as a code owner October 21, 2020 11:35
@vcunat
Copy link
Member

vcunat commented Oct 21, 2020

libical regressed:

  The following tests FAILED:
           1 - regression (SEGFAULT)
     36 - recur (SEGFAULT)
          41 - timezones (Failed)
        45 - libical-glib-array (Failed)
       47 - libical-glib-component (Failed)
           56 - libical-glib-timezone (Failed)

(reproduced multiple times on two of my machines, too)

@cdepillabout cdepillabout self-requested a review as a code owner October 24, 2020 08:34
@ofborg ofborg bot removed the 6.topic: python label Oct 25, 2020
@jonringer
Copy link
Contributor

@GrahamcOfBorg test installer.simple

@FRidh
Copy link
Member Author

FRidh commented Oct 30, 2020

libical test failures are due to the tzdata bump in 8904ce2. Basically, the tests need updating. libical/libical#449

@FRidh
Copy link
Member Author

FRidh commented Oct 30, 2020

I have not been able to disable the failing tests of libical using --exclude-regex.

jtojnar and others added 6 commits October 31, 2020 13:45
@FRidh
Copy link
Member Author

FRidh commented Nov 1, 2020 •
edited

@vcunat this is strange, github reports there are only few commits that are going to be merged with this PR. I was under the impression there were more, but I may very well be wrong.

@jansol
Copy link
Contributor

jansol commented Nov 1, 2020 •
edited

@FRidh there used to be until this

Or rather until the cleanup after that

roberth and others added 2 commits November 3, 2020 12:01
@roberth
haskell.compiler.ghc8102BinaryMinimal: init
f8ad73b 
To stay within hydra limit of 2^31 output size on aarch64-linux
@FRidh
Merge master into staging-next
2379662
@primeos primeos mentioned this pull request Nov 3, 2020
Closed
@FRidh FRidh merged commit 49cd730 into master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@jonringer jonringer Awaiting requested review from jonringer

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@zowoq zowoq Awaiting requested review from zowoq zowoq is a code owner

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@edolstra edolstra Awaiting requested review from edolstra

@peti peti Awaiting requested review from peti

@kalbasit kalbasit Awaiting requested review from kalbasit kalbasit is a code owner

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice thoughtpolice is a code owner

Assignees
No one assigned
Labels
6.topic: golang 6.topic: haskell 6.topic: python 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet