nixos/ldap: restart nslcd when configuration changes #101224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I noticed that the
restartTriggers
in this module were wrong.Note that this new value for
restartTriggers
is a best effort - we can't tell if the content of a password file has changed, so we assume the content of a password file is different if the path to the password file has changed. Another option is to only pass the contents of the configuration file torestartTriggers
and have the user manually restart the service if the password changes. Or tell the user to utilize something likenix-sops
🤷♂️Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)