Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yamale: init at 3.0.4 #101208

Merged
merged 2 commits into from Oct 21, 2020
Merged

yamale: init at 3.0.4 #101208

merged 2 commits into from Oct 21, 2020

Conversation

rtburns-jpl
Copy link
Contributor

Adds Yamale, an MIT-licensed schema and validator for YAML developed by 23andMe.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Oct 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second commit should be:

python3Packages.yamale: init at 3.0.4

otherwise LGTM

@jonringer
Copy link
Contributor

Also, thanks for opening your first PR against Nixpkgs @rtburns-jpl :)

jonringer
jonringer reviewed Oct 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks like it can be used as a cli tool https://github.com/23andMe/Yamale#command-line

please add the following to all-packages.nix

  yamale = with python3Packages; toPythonApplication yamale;

this addition should be amended to the addition commit

jonringer
jonringer approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/101208
2 packages built:
python37Packages.yamale yamale

@jonringer jonringer merged commit 40e9a23 into NixOS:master Oct 21, 2020
@rtburns-jpl rtburns-jpl deleted the yamale branch October 21, 2020 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rtburns-jpl @jonringer @Janik-Haag