Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: The MSYS builds fail on most recent PRs. #9778

Closed
James103 opened this issue Jan 1, 2022 · 1 comment
Closed

[Bug]: The MSYS builds fail on most recent PRs. #9778

James103 opened this issue Jan 1, 2022 · 1 comment

Comments

@James103
Copy link
Contributor

James103 commented Jan 1, 2022 •
edited

Version of OpenTTD

See: #9769, #9759, and similar

Expected result

The MSYS builds pass without any errors.

Actual result

Even for PRs that are completely unrelated to the game code at all (i.e. PRs that never touch the game's code), the MSYS builds fail with the following error:

  CMakeFiles/openttd.dir/objects.a(network_command.cpp.obj):network_command.cpp:(.pdata$_ZNSt11_Tuple_implILy6EJjEEC2IRjEEOT_+0x0): relocation truncated to fit: IMAGE_REL_AMD64_ADDR32NB against `.text$_ZNSt11_Tuple_implILy6EJjEEC2IRjEEOT_'
  CMakeFiles/openttd.dir/objects.a(network_command.cpp.obj):network_command.cpp:(.pdata$_ZNSt11_Tuple_implILy6EJjEEC2IRjEEOT_+0x4): relocation truncated to fit: IMAGE_REL_AMD64_ADDR32NB against `.text$_ZNSt11_Tuple_implILy6EJjEEC2IRjEEOT_'
  CMakeFiles/openttd.dir/objects.a(network_command.cpp.obj):network_command.cpp:(.pdata$_ZNSt11_Tuple_implILy6EJjEEC2IRjEEOT_+0x8): relocation truncated to fit: IMAGE_REL_AMD64_ADDR32NB against `.xdata$_ZNSt11_Tuple_implILy6EJjEEC2IRjEEOT_'
  CMakeFiles/openttd.dir/objects.a(network_command.cpp.obj):network_command.cpp:(.pdata$_ZNSt11_Tuple_implILy5EJ13SignalVariantbbbhEEC2IRS0_JRbS4_S4_RhEvEEOT_DpOT0_+0x0): relocation truncated to fit: IMAGE_REL_AMD64_ADDR32NB against `.text$_ZNSt11_Tuple_implILy5EJ13SignalVariantbbbhEEC2IRS0_JRbS4_S4_RhEvEEOT_DpOT0_'
  CMakeFiles/openttd.dir/objects.a(network_command.cpp.obj):network_command.cpp:(.pdata$_ZNSt11_Tuple_implILy5EJ13SignalVariantbbbhEEC2IRS0_JRbS4_S4_RhEvEEOT_DpOT0_+0x4): relocation truncated to fit: IMAGE_REL_AMD64_ADDR32NB against `.text$_ZNSt11_Tuple_implILy5EJ13SignalVariantbbbhEEC2IRS0_JRbS4_S4_RhEvEEOT_DpOT0_'
  CMakeFiles/openttd.dir/objects.a(network_command.cpp.obj):network_command.cpp:(.pdata$_ZNSt11_Tuple_implILy5EJ13SignalVariantbbbhEEC2IRS0_JRbS4_S4_RhEvEEOT_DpOT0_+0x8): relocation truncated to fit: IMAGE_REL_AMD64_ADDR32NB against `.xdata$_ZNSt11_Tuple_implILy5EJ13SignalVariantbbbhEEC2IRS0_JRbS4_S4_RhEvEEOT_DpOT0_'
  CMakeFiles/openttd.dir/objects.a(network_command.cpp.obj):network_command.cpp:(.pdata$_ZNSt10_Head_baseILy4E10SignalTypeLb0EEC2IRS0_EEOT_+0x0): relocation truncated to fit: IMAGE_REL_AMD64_ADDR32NB against `.text$_ZNSt10_Head_baseILy4E10SignalTypeLb0EEC2IRS0_EEOT_'
  CMakeFiles/openttd.dir/objects.a(network_command.cpp.obj):network_command.cpp:(.pdata$_ZNSt10_Head_baseILy4E10SignalTypeLb0EEC2IRS0_EEOT_+0x4): relocation truncated to fit: IMAGE_REL_AMD64_ADDR32NB against `.text$_ZNSt10_Head_baseILy4E10SignalTypeLb0EEC2IRS0_EEOT_'
  CMakeFiles/openttd.dir/objects.a(network_command.cpp.obj):network_command.cpp:(.pdata$_ZNSt10_Head_baseILy4E10SignalTypeLb0EEC2IRS0_EEOT_+0x8): relocation truncated to fit: IMAGE_REL_AMD64_ADDR32NB against `.xdata$_ZNSt10_Head_baseILy4E10SignalTypeLb0EEC2IRS0_EEOT_'
  CMakeFiles/openttd.dir/objects.a(network_command.cpp.obj):network_command.cpp:(.pdata$_ZNSt10_Head_baseILy4ERK21VehicleListIdentifierLb0EEC2ES2_+0x0): relocation truncated to fit: IMAGE_REL_AMD64_ADDR32NB against `.text$_ZNSt10_Head_baseILy4ERK21VehicleListIdentifierLb0EEC2ES2_'
  CMakeFiles/openttd.dir/objects.a(network_command.cpp.obj):network_command.cpp:(.pdata$_ZNSt10_Head_baseILy4ERK21VehicleListIdentifierLb0EEC2ES2_+0x4): additional relocation overflows omitted from the output
  collect2.exe: error: ld returned 1 exit status
  make[2]: *** [CMakeFiles/openttd.dir/build.make:6815: openttd.exe] Error 1
  make[1]: *** [CMakeFiles/Makefile2:983: CMakeFiles/openttd.dir/all] Error 2
  make: *** [Makefile:166: all] Error 2
  Error: Process completed with exit code 2.

Steps to reproduce

  1. Create a PR to merge into the master branch for this repository. The PR does not even have to touch the game code.
  2. Notice that it is quite likely that one of the MSYS builds (typically the x86-64 build) will fail with the above error.

Edit: Disregard this (fixed with c85557e), but it would be nice to rerun the failing workflows to make sure everything still works.
@LordAro
Copy link
Member

LordAro commented Jan 1, 2022

Already fixed by #9773 as you say

We can't rerun existing PRs unless they're rebased, as they still contain the old (broken) method of compiling on MSYS. Encourage PR authors to rebase instead

@LordAro LordAro closed this as completed Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LordAro @James103