New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #9059: Add buttons to toggle music in the Game Options menu. #9727
Conversation
It starts to get messy, and at this point maybe it's better to just add a button to the main menu to open the Jukebox window. |
I second the suggestion of adding a button to open the Jukebox window. More functionality with less code duplication, etc. A possible complication: the way music is currently set up, only song 00 is available in the main menu, and it is not available in any of the main game programmes (except custom programmes). If the Jukebox was added to the main menu screen, it might need either a hidden main menu programme which contains only 00, or for this behavior to change to allow all songs to play in the main menu.
|
Ok, I will try implementing the Jukebox idea some time this weekend. Thank you for the feedback. |
@2TallTyler I made a mockup of what I mean by showing the list right away. As it is, the music on the main menu is already implemented via a sixth "secret" playlist that only contains the title theme song. |
I rescind my -1 to your solution. That looks pretty slick. |
Okay, I've changed it so that the jukebox is now accessible via the game options menu. Like discussed in the comments above, the jukebox only allows you to access song 00, but you can start and stop the music using it. I will note that doing this is somewhat silly looking, since the jukebox opens in the upper left corner of the game's window by default. Note: Should I squash these two commits into one commit for this PR? (I did read through Here is an image of what the UI now looks like below. I used the same sprite image that the toolbar uses for opening the jukebox. I'm not sure if it's clear in this context. Should I use a text button instead? |
Seeing how players get confused with simplest things when it comes to basesets I feel like this approach is not as obvious as you think. Mute button is a universally recognizable symbol, big scary block with bunch of text and buttons is not. Especially in a panic mute situation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know, I think I agree with @LC-Zorg that the button below the volume slider looks a bit nicer. Might be trickier to implement though, depending on how flexible that text widget is.
Probably needs some experimentation with different icon/text zoom levels as well
Good work!
@a2aaron Are you interested in finishing this PR with the requested changes? I'm making an effort to review and approve "low-hanging fruit" PRs and this is on my list. 🙂 |
Sure, I can make the changes later tonight! |
Alright, I've made the changes! I did the two minor style changes (i'm deciding to keep the braces in the switch case, since I think it looks more in line with the other code blocks around it). I also was able to move the Open Jukebox widget below the volume slider as requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
01c0d22
to
2dd44c6
Compare
Motivation / Problem
Players could not start or stop playing music while on the title screen. This would mean that, if you stopped music during gameplay and return to the titlescreen, the music would still be stopped and there would be no way to restart it unless you went into a game and turned it back on. This PR addresses this issue by allowing you to turn the music on in the titlescreen.
Closes #9059
Description
This is a small enhancement to allow the player to play or stop music while on the title screen by adding start and stop buttons to the Game Options menu. They are located next to the music volume widget.
Limitations
There was discussion on the issue (#9059) that adding buttons might clutter the interface and that it would be better if the music simply auto-played when you selected a new music set, but it didn't seem like there was any followup. I can change this PR to do that, (although personally I think having explicit buttons is clearer and doesn't add much clutter)
Also, I ended up using the existing play and stop sprites that are used for the actual music GUI, but I'm not sure if those look the best. I can make some sprites if people do not think they fit very well.
Checklist for review
None of the below bullet points apply.
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.