Change: add a timestamp in name of crash files #9761
Conversation
|
I think there's a windows error message referencing crash.log somewhere as well Also, the issue template :) |
glx22
force-pushed
the
timestamp_crash
branch
from
3281fab to
8724002
Compare
|
Windows crash dialog says something about |
src/crashlog.cpp
Outdated
| * @param filename The begin where to write at. | ||
| * @param filename_last The last position in the buffer to write to. | ||
| * @param ext The extension for the filename. | ||
| * @param with_dir Wether to append directory in front of filename. |
There was a problem hiding this comment.
s/wether/whether/
Maybe something like "Whether to suffix the file name with the directory"? Not sure whether "append ... in front" or "suffix" would be the prefered way to write it in English though.
| static std::string crashname; | ||
|
|
||
| if (crashname.empty()) { | ||
| UTCTime::Format(filename, filename_last, "crash%Y%m%d%H%M%S"); |
There was a problem hiding this comment.
I wonder how likely it is for this to trigger an allocation that OOMs the crashlog when its being generated. I seem to remember we were fairly wary about memory allocation before at least the crash log and dump were written. Not sure how big a problem it is, because it's a very small amount of memory that gets allocated though.
There was a problem hiding this comment.
On POSIX platforms at least, strictly speaking you should not call malloc or similar functions from a signal handler (including the crash log handler) because these are not re-entrant or signal-safe. OOM is not really an issue because if it happens it's more likely that the OOM killer will kill the whole process outright anyway. In the vast majority of cases you can get away with using malloc, and indeed the backtrace call implementations in the Unix crash log handler call malloc.
On Windows both writing the crash log and showing the dialog with the crash log contents in will allocate vastly more memory than this, so if an OOM event occurs any crash log will never make it to the user.
This string content here is short enough that it'll probably fit into the inline buffer anyway.
LordAro
added
the
backport requested
glx22
force-pushed
the
timestamp_crash
branch
from
8724002 to
2933c7b
Compare
TrueBrain
added
backported
Motivation / Problem
When a crash happens, it overwrites previous crash files.
But different crash may happen before a player decides to open an issue, and they can have very different causes.
Description
Add a timestamp to the filenames, so newer crashes don't overwrite maybe useful data from previous crashes.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.