Fix vector.from_string returning a table without vector metatable

minetest · Jan 3, 2022 · 1965628 · 1965628
1 parent 84fdd36
commit 1965628
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/builtin/common/tests/vector_spec.lua b/builtin/common/tests/vector_spec.lua
@@ -300,6 +300,7 @@ describe("vector", function()
 
 	it("from_string()", function()
 		local v = vector.new(1, 2, 3.14)
+		assert.is_true(vector.check(vector.from_string("(1, 2, 3.14)")))
 		assert.same({v, 13}, {vector.from_string("(1, 2, 3.14)")})
 		assert.same({v, 12}, {vector.from_string("(1,2 ,3.14)")})
 		assert.same({v, 12}, {vector.from_string("(1,2,3.14,)")})

diff --git a/builtin/common/vector.lua b/builtin/common/vector.lua
@@ -61,7 +61,7 @@ function vector.from_string(s, init)
 	if not (x and y and z) then
 		return nil
 	end
-	return {x = x, y = y, z = z}, np
+	return fast_new(x, y, z), np
 end
 
 function vector.to_string(v)