Fix 68f2213: Don't use GetPoolSize() for end of pool iterator #9461
Conversation
There was a problem hiding this comment.
Might solve #9458, but definitely solves a desync via the Vehicle tick counter creating effect vehicles that might not get iterated over.
This as the range based for loop gets end, i.e the original pool size (or actually the highest ID ever assigned), and iterates up to there. If the game already ran a while that highest ID might be significantly higher than the current highest ID, so a joining client would have a lower highest ID, and thus a lower pool size and thus a lower 'value' for end(). This means that in the existing clients the effect vehicle created in the vehicle tick gets iterated over, whereas it does not in the newly joined client causing a divergence in state and eventual desync. Especially as the effect vehicle will be removed earlier, and all assigned vehicle IDs may be off after that event.
rubidium42
added
the
backport requested
TrueBrain
removed
the
backport requested
Motivation / Problem
GetPoolSize()returned value can change during the pool iteration, so using it forend()was not a good idea.Description
Use a constant (max size of the pool) for
end(), and setindexto this value whenever it reachesGetPoolSize().Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.