Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 14f197c: [Script] int64 values don't fit into int #9465

Merged
merged 1 commit into from Aug 10, 2021
Merged

Fix 14f197c: [Script] int64 values don't fit into int #9465

merged 1 commit into from Aug 10, 2021

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Aug 10, 2021

Motivation / Problem

GS crashes when using foreach if key/value >MAX_INT32. This is because ScriptList::_nexti() temporary stores the int64 value into an int.

Description

Use a 64bit container for the temp value.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@rubidium42 rubidium42 added the backport requested This PR should be backport to current release (RC / stable) label Aug 10, 2021
@glx22 glx22 merged commit 4eb368c into OpenTTD:master Aug 10, 2021
@glx22 glx22 deleted the _nexti branch August 10, 2021 17:01
@andythenorth andythenorth mentioned this pull request Aug 10, 2021
Merged
@TrueBrain TrueBrain removed the backport requested This PR should be backport to current release (RC / stable) label Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain TrueBrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glx22 @TrueBrain @rubidium42