Change: remove the ability to control "max spectators" #9466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soon we will make "join game" join the game as spectator first, so limiting the amount of spectators makes no sense anymore in that context. Not sure it ever did make sense.
TrueBrain
force-pushed
the
no-more-max-spectators
branch
from
97addfe
to
4d82681
Compare
LordAro
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
We want to remove the "lobby" window, as it is just an annoying window. As replacement, the "Join Game" button will join the game as spectator, from which you can move to a (new) company.
In order to get there, we need to remove "max spectators", as if you set spectators to 0, it would mean nobody can join.
Honestly, I am not sure "max spectators" has ever been useful.
Description
Removed max-spectators. For master-server info, replaced it with "max-clients" for now, as that is basically the next value .. you can never have more spectators than "max-clients" :D
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.