Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 8706dcd9: [Script] Byte-swap grfids to match normal expectations. #9468

Merged
merged 1 commit into from Aug 10, 2021
Merged

Fix 8706dcd9: [Script] Byte-swap grfids to match normal expectations. #9468

merged 1 commit into from Aug 10, 2021

Conversation

michicc
Copy link
Member

@michicc michicc commented Aug 10, 2021

Motivation / Problem / Description

Grfids are generally expected to be presented in a big-endian format. Swap internal grfids in the script API to match expectations.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@michicc michicc added the needs review: Script API Review requested from GS/AI expert label Aug 10, 2021
@michicc michicc merged commit b146818 into OpenTTD:master Aug 10, 2021
@michicc michicc deleted the pr/script_newgrf branch August 10, 2021 19:35
@andythenorth
Copy link
Contributor

Works as expected for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain TrueBrain approved these changes

Assignees
No one assigned
Labels
needs review: Script API Review requested from GS/AI expert
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michicc @andythenorth @TrueBrain