Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: name the Online Players caption the same as in the menu #9473

Merged
merged 1 commit into from
Aug 14, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

Found a boo-boo while looking at a screenshot. Go figure.

In the menu it is called "Online Players".
In the caption it is called "Multiplayer".

That is just confusing. A window should have a single identity, not two.

Description

Renamed the caption, as I think "Online Players" is a more clear description.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Referring to one window in two ways is a bit annoying.
@TrueBrain TrueBrain merged commit 132c540 into OpenTTD:master Aug 14, 2021
@TrueBrain TrueBrain deleted the fix-online-player-caption branch August 14, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants