Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2594c74b67c7
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c60a5a58becc
Choose a head ref
  • 3 commits
  • 1 file changed
  • 1 contributor

Commits on Aug 4, 2021

  1. slow save

    eggrobin committed Aug 4, 2021
    Copy the full SHA
    d50b1a5 View commit details
  2. lint

    eggrobin committed Aug 4, 2021
    Copy the full SHA
    71c2bff View commit details
  3. Merge pull request #3080 from eggrobin/reach

    Do not test Reach’s save in debug
    eggrobin authored Aug 4, 2021
    Copy the full SHA
    c60a5a5 View commit details
Showing with 7 additions and 4 deletions.
  1. +7 −4 ksp_plugin_test/plugin_compatibility_test.cpp
11 changes: 7 additions & 4 deletions ksp_plugin_test/plugin_compatibility_test.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@

#include <memory>
#include <string>
#include <utility>
#include <vector>

#include "astronomy/time_scales.hpp"
@@ -46,7 +47,7 @@ const char preferred_encoder[] = "base64";

class StringLogSink : google::LogSink {
public:
StringLogSink(google::LogSeverity const minimal_severity)
explicit StringLogSink(google::LogSeverity const minimal_severity)
: minimal_severity_(minimal_severity) {
google::AddLogSink(this);
}
@@ -148,7 +149,8 @@ class PluginCompatibilityTest : public testing::Test {
principia__DeletePlugin(&released_plugin);
}

static void WriteAndReadBack(not_null<std::unique_ptr<Plugin const>> plugin1) {
static void WriteAndReadBack(
not_null<std::unique_ptr<Plugin const>> plugin1) {
// Write the plugin to a new file with the preferred format.
WritePluginToFile(TEMP_DIR / "serialized_plugin.proto.b64",
preferred_compressor,
@@ -187,10 +189,10 @@ TEST_F(PluginCompatibilityTest, PreCohen) {
HasSubstr(
"pre-Cohen ContinuousTrajectory"), // Regression test for #3039.
HasSubstr("pre-Cauchy"), // The save is even older.
Not(HasSubstr("pre-Cartan")) // But not *that* old.
));
Not(HasSubstr("pre-Cartan")))); // But not *that* old.
}

#if !_DEBUG
TEST_F(PluginCompatibilityTest, Reach) {
StringLogSink log_warning(google::WARNING);
not_null<std::unique_ptr<Plugin const>> plugin = ReadPluginFromFile(
@@ -263,6 +265,7 @@ TEST_F(PluginCompatibilityTest, Reach) {
// Make sure that we can upgrade, save, and reload.
WriteAndReadBack(std::move(plugin));
}
#endif

// Use for debugging saves given by users.
TEST_F(PluginCompatibilityTest, DISABLED_SECULAR_Debug) {