Skip to content

Commit 1ab29f1

Browse files
authoredAug 8, 2021
Fix GUIEditBoxWithScrollBar using a smaller steps than intlGUIEditBox (#11519)
1 parent c6eddb0 commit 1ab29f1

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed
 

Diff for: ‎src/gui/guiEditBoxWithScrollbar.cpp

+13-2
Original file line numberDiff line numberDiff line change
@@ -620,6 +620,17 @@ void GUIEditBoxWithScrollBar::createVScrollBar()
620620
if (Environment)
621621
skin = Environment->getSkin();
622622

623+
s32 fontHeight = 1;
624+
625+
if (m_override_font) {
626+
fontHeight = m_override_font->getDimension(L"Ay").Height;
627+
} else {
628+
IGUIFont *font;
629+
if (skin && (font = skin->getFont())) {
630+
fontHeight = font->getDimension(L"Ay").Height;
631+
}
632+
}
633+
623634
m_scrollbar_width = skin ? skin->getSize(gui::EGDS_SCROLLBAR_SIZE) : 16;
624635

625636
irr::core::rect<s32> scrollbarrect = m_frame_rect;
@@ -628,8 +639,8 @@ void GUIEditBoxWithScrollBar::createVScrollBar()
628639
scrollbarrect, false, true);
629640

630641
m_vscrollbar->setVisible(false);
631-
m_vscrollbar->setSmallStep(1);
632-
m_vscrollbar->setLargeStep(1);
642+
m_vscrollbar->setSmallStep(3 * fontHeight);
643+
m_vscrollbar->setLargeStep(10 * fontHeight);
633644
}
634645

635646

Diff for: ‎util/ci/clang-format-whitelist.txt

-2
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,6 @@ src/gui/guiTable.cpp
192192
src/gui/guiTable.h
193193
src/gui/guiVolumeChange.cpp
194194
src/gui/guiVolumeChange.h
195-
src/gui/intlGUIEditBox.cpp
196-
src/gui/intlGUIEditBox.h
197195
src/gui/mainmenumanager.h
198196
src/gui/modalMenu.h
199197
src/guiscalingfilter.cpp

0 commit comments

Comments
 (0)
Please sign in to comment.