Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate technical terms in the new frame selector UI #3092

Merged
merged 3 commits into from
Aug 13, 2021

Conversation

eggrobin
Copy link
Member

Also tweak the English terms a bit (JSO rather than JCSO, consistent with, e.g., Juno terminology).

Use acronyms (ECI, ECEF, JSO, etc.) for both the selector buttons and the navball text when patterns for them are provided; otherwise, use a generic short description on the buttons (Inertial frame, Body-fixed frame, Orbital frame), and the full names on the navball.

Use the localized celestial names (this matters in RSS).

The reference frame descriptions and tooltips have not yet been translated.

@@ -121,6 +120,7 @@
<Compile Include="ksp_plugin_adapter.cs" />
<Compile Include="interface.cs" />
<Compile Include="loader.cs" />
<Compile Include="localizer_extensions.cs" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localisation

Sorry, something went wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-ization even (oxendict).

Sorry, something went wrong.

@pleroy pleroy added the LGTM label Aug 13, 2021
@eggrobin eggrobin merged commit c4952aa into mockingbirdnest:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants