Refactor the ReferenceFrameSelector API #3085
Merged
+190
−126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge before Grothendieck.
This pull request mostly makes the API of ReferenceFrameSelector less dependent on the UI (most notably doing away with the concept of a selected celestial).
Its observable effect is to make it so that the target frame always uses the primary of the target (in the stock sense for now).
This is a preparatory step for an overhaul of the frame selection UI.