Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the ReferenceFrameSelector API #3085

Merged

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Aug 6, 2021

Do not merge before Grothendieck.

This pull request mostly makes the API of ReferenceFrameSelector less dependent on the UI (most notably doing away with the concept of a selected celestial).

Its observable effect is to make it so that the target frame always uses the primary of the target (in the stock sense for now).

This is a preparatory step for an overhaul of the frame selection UI.

double separation = (target_vessel.GetWorldPos3D() -
properties.world_position).magnitude;
double separation =
(properties.reference_frame.target.GetWorldPos3D() -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad indent.

Sorry, something went wrong.

@pleroy pleroy added the LGTM label Aug 8, 2021
@eggrobin eggrobin merged commit ca535f3 into mockingbirdnest:master Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants