Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs related to forgetting #3182

Merged
merged 2 commits into from
Oct 30, 2021

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Oct 30, 2021

  1. ForgetAfter should not delete all the segments, it should at least keep one empty segment.
  2. Forgetting by iterator should support the past-the-end iterator.

#3136.

@eggrobin eggrobin added the LGTM label Oct 30, 2021
@pleroy pleroy merged commit 43037ba into mockingbirdnest:delaValléePoussin Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants