Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9669, cbe00ec: Only try valid reverse directions #9672

Merged
merged 1 commit into from Nov 6, 2021
Merged

Fix #9669, cbe00ec: Only try valid reverse directions #9672

merged 1 commit into from Nov 6, 2021

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Nov 4, 2021

Motivation / Problem

Locks and ship depots only allow axial directions, but that is not enforced on dead end smart ship reverse check.

Description

Limit the smart reverse check to only valid trackdirs.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@glx22 glx22 added the backport requested This PR should be backport to current release (RC / stable) label Nov 4, 2021
@glx22 glx22 merged commit 6ff0858 into OpenTTD:master Nov 6, 2021
@glx22 glx22 deleted the fix_9669 branch November 6, 2021 16:32
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Nov 7, 2021
@glx22 @TrueBrain
Fix OpenTTD#9669, cbe00ec: Only try valid reverse directions (OpenTTD…
509d496 
…#9672)
@TrueBrain TrueBrain mentioned this pull request Nov 7, 2021
Merged
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Nov 7, 2021
TrueBrain pushed a commit that referenced this pull request Nov 7, 2021
@glx22 @TrueBrain
Fix #9669, cbe00ec: Only try valid reverse directions (#9672)
84580a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JGRennison JGRennison JGRennison left review comments

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@glx22 @JGRennison @LordAro @TrueBrain