Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated data in GC_LISTING packet #76

Closed
TheDude-gh opened this issue Nov 3, 2021 · 2 comments · Fixed by #77
Closed

Duplicated data in GC_LISTING packet #76

TheDude-gh opened this issue Nov 3, 2021 · 2 comments · Fixed by #77

Comments

@TheDude-gh
Copy link

TheDude-gh commented Nov 3, 2021

As mentioned in #74 , the GC_LISTING packet returns lot of duplicated NewGRF entries.

With new system, I would expect there will be entires like this:
ID NEWGRF_ID NEWGRF_MD5 NEWGRF NAME

once for every unique combination. The ID is used in ServerInfo part to assign NewGRF to server.

What is observed is many duplicated combinations of the NEWGRF_ID NEWGRF_MD5 NEWGRF NAME, but with different ID.
Which is kind of redundant.

Seems like game controller does not properly check if the NewGRF already exists in the list.

At this moment there is ~6000 entries in the packet, while only ~1500 is actually unique, meaning 4500 entries are redundant.

Example of decoded GRF part from GC_LISTING packet

(removed attachment as it contains information we are not free to distribute)

@TrueBrain
Copy link
Member

The packet in question is NEWGRF_LOOKUP, not GC_LISTING. The latter only returns indexes into the first table. The first returns the table. This to not confuse anyone looking into this :)

@TheDude-gh
Copy link
Author

Cool.

(removed attachment as it contains information we are not free to distribute)

What does this mean? The attached file did not contained any sensitive information, or did it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants