Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Every 16th client never reconnects after server restart #9666

Merged
merged 1 commit into from Nov 3, 2021

Conversation

ldpl
Copy link
Contributor

@ldpl ldpl commented Nov 3, 2021

Motivation / Problem

If client id is divisible by 16 he gets stuck with "server is restarting message" when the server restarts and never attempts to reconnect.

Steps to reproduce

  1. Start the server.
  2. Connect the client so his id is divisible by 16 (refreshing server a bunch of times helps to get it faster).
  3. Type newgame in server console.
  4. Client gets the server restarting message but never reconnects

Description

Add +1 to _network_reconnect as value 0 means no reconnect.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@ldpl ldpl changed the title Fix: Every 16th client gets stuck wating for server restart Fix: Every 16th client never reconnects after server restart Nov 3, 2021
@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Nov 3, 2021
@rubidium42 rubidium42 merged commit 80e3397 into OpenTTD:master Nov 3, 2021
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Nov 7, 2021
@ldpl ldpl deleted the fix-16th-restart branch November 7, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants