Fix: stale NewGRF entries not removed from NewGRF lookup table #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The field "grfid" in a NewGRF should be an integer. The expire event sends it as string, but didn't convert it back to an integer. In result, the expire routine failed to remove NewGRFs from the lookup table. This means the table only grew, until the instance was reset again.
glx22
approved these changes
Nov 3, 2021
TrueBrain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
The field "grfid" in a NewGRF should be an integer. The expire event
sends it as string, but didn't convert it back to an integer. In result,
the expire routine failed to remove NewGRFs from the lookup table.
This means the table only grew, until the instance was reset again.