New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"File version" is incorrect for Windows OpenTTD executable #9062
Comments
This is something that should be borne in mind for the future. It is obviously not possible to fix this for 1.11.1... |
Quickly checked source, master also shows 1.11.0.xxxx |
Curious. OpenTTD/CPackProperties.cmake.in Line 2 in f757d07
But CPACK_PACKAGE_VERSION is an internal cpack variable, perhaps it's getting confused/reused somehow? |
|
|
|
The OS/2 installer stuff there is somewhat redundant; "modern" OS/2 appears to use RPM for package distribution. At some point I intend to update the OS/2 stuff, I'd just ignore it for now. |
Version of OpenTTD
OpenTTD 1.11.1
from the build artifacts foropenttd-1.11.1-windows-win64
oropenttd-1.11.1-windows-win32
Expected result
The "File version" that is part of the
openttd.exe
metadata should say1.11.1.25330
(next:1.11.2.25330
).Actual result
The "File version" that is part of the
openttd.exe
metadata says1.11.0.25330
. Reinstalling the game from the installer still leaves the value1.11.0.25330
for the file version, and so does installing the game from the zip archive.Steps to reproduce
openttd-1.11.1-windows-win64
oropenttd-1.11.1-windows-win32
(zip archive or installer) onto a Windows 10 device.File version
in the tooltip that comes up when you hover overopenttd.exe
.1.11.0.25330
and not the expected1.11.1.25330
(next:1.11.2.25330
).The text was updated successfully, but these errors were encountered: