Fix: [CMake] Don't include regression AIs in bundles #9068
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glx22
added
the
backport requested
glx22
commented
Apr 20, 2021
glx22
changed the title
|
Which version do you mean by "this version" ? I don't particularly mind either way, though working well from an unclean checkout is a positive |
|
"this version" is the install from build dir with a regex to remove regression AI :) |
LordAro
approved these changes
Apr 20, 2021
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
May 1, 2021
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
May 1, 2021
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
May 2, 2021
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
May 2, 2021
LordAro
pushed a commit
that referenced
this pull request
May 3, 2021
LordAro
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
In #8906, I though it was a smart move to install script compat files from build dir. But I was forgetting regression AIs were also in this directory. And they ended up in bundles.
Description
This is a revert of the install related changes I made in #8906.
I then excluded any
CMakeLists.txtfrom installation.I tried another option, using build dir as install source, but the regex to filter AIs subdirs was way harder to read (I'll show it in a suggestion comment).
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.