Few things to cleanup in the network code #9069
Merged
+46
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
reviewed
Apr 20, 2021
One also looks for a company, the other doesn't. There were more uses of the latter than the first, leaving very weird code all over the place.
…ndler When ever you saw this debug lines (which you never should), they showed an empty address. It is also not very useful to have, as it always points to a known server anyway.
Strictly seen the comment is true, as it says 'e.g.', but it is misleading. The server name is just that: the name of the server as configured. No need to mention advertising.
TrueBrain
force-pushed
the
network-cleanup
branch
from
7d72052 to
21482a6
Compare
LordAro
approved these changes
Apr 20, 2021
glx22
reviewed
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
While working on adding STUN to the network code, I found some bits and pieces that are not really doing it for me. So I addressed them :D
Description
ParseConnectionStringwas, most likely out of laziness, abused a few times. I un-lazied-it.Nothing shocking here, just upkeep.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.