Change: merge duplicate logic to scroll in lists by key into a single location #9053
+86
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsmh
reviewed
Apr 18, 2021
src/widget.cpp
Outdated
| @@ -1974,6 +1974,66 @@ int Scrollbar::GetScrolledRowFromWidget(int clickpos, const Window * const w, in | |||
| return (pos >= this->GetCount()) ? INT_MAX : pos; | |||
| } | |||
|
|
|||
| /** | |||
| * Update the given list position as if it were on this scroll bar when the given key_code was pressed. | |||
There was a problem hiding this comment.
This took me several tries to understand but I can't think of a better way to word it either.
rubidium42
force-pushed
the
unduplicated_key_list_position_logic
branch
from
a88d766 to
eee6848
Compare
LordAro
reviewed
Apr 20, 2021
rubidium42
force-pushed
the
unduplicated_key_list_position_logic
branch
from
eee6848 to
e673b62
Compare
|
This is actually a codechange rather than a change, no? (Should have noticed before, my bad) |
rubidium42
force-pushed
the
unduplicated_key_list_position_logic
branch
from
e673b62 to
2dca768
Compare
LordAro
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Reading #9011 I saw the code for handled up/down/page down/page up/home/end in lists in the NewGRF UI getting duplicated. This triggered me to look at other places with the same logic, and there were three with all mostly the same code with slight variations where they did the validations.
Code that is copied twice, and might be copied for a third time is not what we should aim for.
Description
Introduce a new function in Scrollbar to handle the list position update logic, and convert the existing versions to that single new one.
Limitations
None?
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.