Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2910 #2944

Merged
merged 3 commits into from
Apr 10, 2021
Merged

Fix #2910 #2944

merged 3 commits into from
Apr 10, 2021

Conversation

c6ForH66
Copy link
Contributor

@c6ForH66 c6ForH66 commented Apr 9, 2021

Fix #2910

@pleroy
Copy link
Member

pleroy commented Apr 10, 2021

Thanks for your contribution. I agree in particular that it seems better to say "Principia" than "多体".

The PR doesn't fully fix #2910 however. There are strings that are probably incorrect here and here (because I had to add/remove parameters), and there is a block of untranslated strings at the end of the file: here, here, here and here (things that were missed in the first round of translations).

It would be really nice if you could update your PR with fixes to these other strings, too, as that would make the zh-cn translation complete.

@pleroy
Copy link
Member

pleroy commented Apr 10, 2021

Thanks, looks good now.

@pleroy pleroy added the LGTM label Apr 10, 2021
@pleroy pleroy merged commit 2759dac into mockingbirdnest:master Apr 10, 2021
@pleroy pleroy added this to the Grassmann milestone Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some strings are untranslated in Chinese.
3 participants