Codecov Report

Merging #607 (62b4d67) into master (c84d4af) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #607   +/-   ##
=======================================
  Coverage   81.50%   81.51%           
=======================================
  Files          49       49           
  Lines        6461     6463    +2     
  Branches     1287     1287           
=======================================
+ Hits         5266     5268    +2     
- Misses       1007     1008    +1     
+ Partials      188      187    -1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84d4af...62b4d67. Read the comment docs.

Why would one want that? Couldn't you use DomainsRenamer ?

I wasn't aware of this option... it felt natural and consistent with e.g. AsyncFIFO to set the clock domain explicitly. As a beginner, I developed the habit of having an explicit domain for most of my modules. I found it easier to reason about, but that might be a bad habit for larger-scale projects or libraries (I guess domain name collision).

I'll start to use DomainRenamer, feel free to close this PR.

Generally the nMigen convention is that modules that work only in one clock domain use the sync domain and are then used in combination with DomainRenamer. The AsyncFIFO spans multiple clock domains and is therefore different.

What @anuejn said is accurate.