Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty formdata in response.formData() #28607

Closed
jimmywarting opened this issue Apr 20, 2021 · 5 comments · Fixed by #28770
Closed

Empty formdata in response.formData() #28607

jimmywarting opened this issue Apr 20, 2021 · 5 comments · Fixed by #28770
Labels
fetch xhr

Comments

@jimmywarting
Copy link
Contributor

This can return a empty FormData in firefox and works fine...

new Response(new FormData()).formData()

Blink & Safari don't support it (if it's empty - need to append at least one item)
Maybe add a test for this?
@foolip
Copy link
Member

foolip commented Apr 23, 2021

cc @annevk

@annevk
Copy link
Member

annevk commented Apr 26, 2021

@jimmywarting are you willing to contribute a test? And file bugs against Chrome/Safari?

@jimmywarting
Copy link
Contributor Author

Are you willing to contribute a test? And file bugs against Chrome/Safari?

file bug report to chrome/safari would be easy - i can do that.

Any pointers for writing a test, like which file to write it in?

@annevk
Copy link
Member

annevk commented Apr 26, 2021

That's great, thanks!

You could add a new .any.js file covering this scenario to https://github.com/web-platform-tests/wpt/tree/master/fetch/api/body.

There's some existing tests in https://github.com/web-platform-tests/wpt/blob/master/fetch/api/response/response-consume.html and https://github.com/web-platform-tests/wpt/blob/master/fetch/api/request/request-consume.any.js but they're fairly large already.

@jimmywarting
Copy link
Contributor Author

file bugs against Chrome/Safari?

@jimmywarting jimmywarting mentioned this issue Apr 30, 2021
Merged
annevk pushed a commit that referenced this issue May 3, 2021
@jimmywarting
Test response/request.formData() when constructed with empty FormData
b9e74d0 
Closes #28607.
@jimmywarting jimmywarting mentioned this issue May 31, 2021
Closed
@jimmywarting jimmywarting mentioned this issue Aug 21, 2022
Closed
@marcosc90 marcosc90 mentioned this issue Oct 5, 2022
Merged
bartlomieju pushed a commit to denoland/deno that referenced this issue Oct 7, 2022
@marcosc90
fix(ext/fetch): support empty formdata (#16165)
a5d55fe 
This PR adds support for empty `FormData` parsing in
`Response`/`Request`

```js
new Response(new FormData()).formData()
```

ref: web-platform-tests/wpt#28607
bartlomieju pushed a commit to denoland/deno that referenced this issue Oct 17, 2022
@marcosc90 @bartlomieju
fix(ext/fetch): support empty formdata (#16165)
bcfd5ad 
This PR adds support for empty `FormData` parsing in
`Response`/`Request`

```js
new Response(new FormData()).formData()
```

ref: web-platform-tests/wpt#28607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fetch xhr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test for decoding empty formdata using fetch jimmywarting/wpt
3 participants
@foolip @jimmywarting @annevk