Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9028: [OpenGL] Clear cursor cache on destroying the OpenGL backend. #9032

Merged
merged 1 commit into from Apr 12, 2021

Conversation

michicc
Copy link
Member

@michicc michicc commented Apr 12, 2021

Motivation / Problem

Since 436cdf1 destroying the OpenGL backend only requested a clear of the cursor cache but didn't actually perform.

Description

Split the cache clear into an internal function so that it can be used on destruction without the request queue logic.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

src/video/opengl.cpp Outdated Show resolved Hide resolved
@michicc michicc merged commit 433602b into OpenTTD:master Apr 12, 2021
@michicc michicc deleted the pr/fix_9028 branch April 12, 2021 20:40
@TrueBrain TrueBrain added the backport requested This PR should be backport to current release (RC / stable) label Apr 13, 2021
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable) component: OpenGL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants