Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ImageDecoder] Remove decodeMetadata() in favor of tracks.ready. #28612

Merged
merged 1 commit into from Apr 22, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 21, 2021

Since metadata is always queued automatically, decodeMetadata()
doesn't really do what it says. There's a better web idiom for
this a 'ready' property that's a one-time resolved promise.

Instead of calling decodeMetadata(), clients should just use
decode.tracks.ready.then(...)

Since the last round of breaking changes didn't cause any
issues without a deprecation period, drop decodeMetadata()
without a deprecation period as well.

Fixed: 1182435

Change-Id: I95317d6daaba9a98a7f33d594b50921800a6fbe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2842034
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874987}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

Since metadata is always queued automatically, decodeMetadata()
doesn't really do what it says. There's a better web idiom for
this a 'ready' property that's a one-time resolved promise.

Instead of calling decodeMetadata(), clients should just use
decode.tracks.ready.then(...)

Since the last round of breaking changes didn't cause any
issues without a deprecation period, drop decodeMetadata()
without a deprecation period as well.

Fixed: 1182435

Change-Id: I95317d6daaba9a98a7f33d594b50921800a6fbe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2842034
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874987}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants