CSP: Move form-action check to the browser #28502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 15, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2797339
branch
3 times, most recently
from
8dc6314
to
e2ce883
Compare
The Content Security Policy check for 'form-action' is a navigational check, that we perform at the moment half in Blink (for the initial URL) and half in the Browser (for redirects). The Browser part is currently implemented in a navigational throttle and is not using the correct policies and context. Thanks to the PolicyContainerHost, this CL simplifies the check in the Browser by removing the FormSubmissionThrottle and moving the check to the NavigationRequest, in the same place where other navigational checks are performed. At the same time, it removes the check from Blink relying to the Browser check also for the initial request URL. Change-Id: I28be978be3c86f1d8ad8b41398542c4e735758e3 Bug: 694525,663512,700964,1172898,1021462,713388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2797339 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#875047}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2797339
branch
from
e2ce883
to
da1d335
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Content Security Policy check for 'form-action' is a navigational
check, that we perform at the moment half in Blink (for the initial
URL) and half in the Browser (for redirects). The Browser part is
currently implemented in a navigational throttle and is not using the
correct policies and context.
Thanks to the PolicyContainerHost, this CL simplifies the check in the
Browser by removing the FormSubmissionThrottle and moving the check to
the NavigationRequest, in the same place where other navigational
checks are performed. At the same time, it removes the check from
Blink relying to the Browser check also for the initial request URL.
Change-Id: I28be978be3c86f1d8ad8b41398542c4e735758e3
Bug: 694525,663512,700964,1172898,1021462,713388
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2797339
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#875047}