Fix: Inconsistent button sizing on AI/GS setting window depending on scale settings. #9044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before this change: After this change: |
|
I would think the taller buttons from before would be more desirable at higher GUI sizes.. |
|
To do that consistently throughout the game is a major challenge. The change here makes the buttons in this particular window match the majority of existing cases in the game, in a fairly minor way. I'm working on another patch which is a more general attempt to fix scaling issues, but it's much larger so less desirable for a backport, and most importantly incomplete... |
LordAro
approved these changes
Apr 17, 2021
LordAro
added
the
backport requested
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
Apr 17, 2021
LordAro
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Inconsistent button sizing on AI/GS setting window depending GUI/font zoom and font size settings.
Description
This is due to a pixel-size being specified for some of the buttons but not all. The widgets with a pixel size are scaled by GUI zoom setting, but the remaining buttons scale purely to fit the text.
This is resolved by removing the minimum pixel height for the buttons it is applied to.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.