Fix: Check for a validly mapped OpenGL screen buffer during driver init. #9007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
added
the
backport requested
|
Indeed so, latest nightly (20210411) should include this fix Note that it doesn't actually fix whatever underlying issue you have, but should hopefully prevent the game from crashing (and fallback to software rendering instead) |
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
Apr 17, 2021
LordAro
pushed a commit
that referenced
this pull request
Apr 18, 2021
LordAro
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
There's some unknown issue during bootstrap that causes a crash due to a an invalid screen pointer (see #8967 and #8969). The exact cause is unknown, but video driver init on SDL/Win32 doesn't check for a validly mapped buffer before suggesting success.
Description
Check for valid mapping on Init, rejecting the OGL driver if not valid and falling back to the next driver.
Limitations
If it is indeed the buffer mapping that fails, this would be a work-around. It is not fixing the real bug in this case though, as there's some underlying reason why the mapping fails.
If the issue is something else, this PR might simply not do anything.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.