Fix #9008: Validate starting year given on the command line. #9014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting year causing all sorts of weird behaviour and crashes in map generation. Now just set the appropriate setting via IConsoleSetSetting so the validation and, if needed, clamping is performed on the starting year value.
LordAro
added
the
backport requested
michicc
approved these changes
Apr 11, 2021
michicc
changed the title
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
Apr 17, 2021
…penTTD#9014) An invalid starting year causes all sorts of weird behaviour and crashes in map generation. Now just set the appropriate setting via IConsoleSetSetting so the validation and, if needed, clamping is performed on the starting year value.
LordAro
pushed a commit
that referenced
this pull request
Apr 18, 2021
An invalid starting year causes all sorts of weird behaviour and crashes in map generation. Now just set the appropriate setting via IConsoleSetSetting so the validation and, if needed, clamping is performed on the starting year value.
LordAro
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
See #9008. The validation on settings should also apply on settings passed through the command line.
Description
The issue is solved by using IConsoleSetSetting, which performs validation and clamping if required, instead of writing the variable directly.
Limitations
It is now using a hard coded string, so any change to the setting name will not break the compilation of the code. It will break the -t command line functionality with an assertion even when the input value is valid, so it ought to be caught relatively quickly.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.