Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Invalidate cached vehicle colourmaps when changing liveries setting. #9006

Merged
merged 1 commit into from Apr 11, 2021

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Apr 10, 2021

Motivation / Problem

Changing the liveries setting "Show vehicle-type specific liveries" does not have an immediately visible effect.
The colour map for individual vehicles is cached, but changing the setting does not invalidate the cache.

Description

This patch resolves this by calling the existing function to locally invalidate all cached vehicle colour maps.

Limitations

Clearing cached colour maps should not have any other side effects. This information is not stored in save games.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN changed the title Fix: Invalid cached vehicle colourmaps when changing liveries setting. Fix: Invalidate cached vehicle colourmaps when changing liveries setting. Apr 10, 2021
@michicc michicc merged commit 31c5b8f into OpenTTD:master Apr 11, 2021
@PeterN PeterN deleted the invalidate-liveries branch April 11, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants