Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9015: Don't set free space value if not requested. #9016

Merged
merged 1 commit into from Apr 11, 2021
Merged

Fix #9015: Don't set free space value if not requested. #9016

merged 1 commit into from Apr 11, 2021

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Apr 11, 2021

Motivation / Problem

As per #9015, entering the console command pwd on Windows causes a crash.

Description

Test if the 'output' parameter for returning free disk space is set before writing to it.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN added the backport requested This PR should be backport to current release (RC / stable) label Apr 11, 2021
@LordAro LordAro merged commit 56f982f into OpenTTD:master Apr 11, 2021
@PeterN PeterN deleted the fix-9015 branch April 11, 2021 12:31
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request Apr 17, 2021
@PeterN @LordAro
Fix OpenTTD#9015: Don't set free space value if not requested. (OpenT…
7b318d2 
…TD#9016)
LordAro pushed a commit that referenced this pull request Apr 18, 2021
@PeterN @LordAro
Fix #9015: Don't set free space value if not requested. (#9016)
5940636
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michicc michicc michicc approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PeterN @michicc @LordAro