Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Query for servers on opening multiplayer window #9003

Closed
wants to merge 1 commit into from
Closed

Change: Query for servers on opening multiplayer window #9003

wants to merge 1 commit into from

Conversation

spnda
Copy link
Contributor

@spnda spnda commented Apr 10, 2021

Motivation / Problem

When a new user starts out with the game and wants to play some multiplayer it could confuse many on why no servers show up. I personally had this issue when starting out and I've seen people ask on the OpenTTD discord on why no servers are showing up. I think in general it simply only adds confusion and I personally don't know any other game that doesn't automatically search.
A few people have pointed out that as soon as one finds why no servers show up, it's just normal to click search.

Description

This makes the game query the master server for all servers when opening the multiplayer window.

Limitations

None, really? Only possibly that some people just want to join a LAN server that then gets lost in-between all other servers.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@nielsmh
Copy link
Contributor

nielsmh commented Apr 10, 2021

As far as I know, the reason it doesn't happen automatically is from a principle of not attempting to contact any servers on the internet without the user actively requesting it. And just clicking Multiplayer on the main menu isn't enough for that, the user might only be interested in LAN play, or in connecting to a friend with a known IP address. But the button could perhaps be made more prominent.

@spnda
Copy link
Contributor Author

spnda commented Apr 10, 2021

I thought of something similar, that maybe one just wants to search LAN and leave it at that. Though then a rewrite of the window might be the only/best solution? I personally think clicking multiplayer wants the player to join a server on most occasions and players less often want to join a LAN server, so giving the user the initial options for servers is not a bad idea, makes most of the players get onto their servers quicker.

@LordAro
Copy link
Member

LordAro commented Apr 11, 2021

Going to vote close on this - I like that it doesn't do anything unless I ask it to (I know content download does, but... that's more explicit?)

The window is definitely in need of a proper redesign though... @TrueBrain ? ;)

@TrueBrain
Copy link
Member

On my list :) And I fully agree this is unclear to users, but doing a network call without them knowing is also not nice. So yeah, redesign.

@TrueBrain TrueBrain closed this Apr 11, 2021
@spnda spnda deleted the multiplayersearch branch April 11, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants