Make web test for SAB in IndexedDB a WPT #28637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 22, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2846500
branch
from
180b506
to
b6f3847
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2846500
branch
from
b6f3847
to
259962b
Compare
The web_test checking that a SharedArrayBuffer cannot be serialized into IndexedDB was failing because it was served inside a non-cross-origin-isolated page, which could not create a SharedArrayBuffer. This CL turns that into a Web Platform Test and adds the appropriate COOP and COEP header which make the page cross-origin-isolated, enabling instantiation of SharedArrayBuffer. Bug: 1194557 Change-Id: I6854a76612d237b82cb020e317459157907e77f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2846500 Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#875562}
jpchase
force-pushed
the
chromium-export-cl-2846500
branch
from
259962b
to
4fd7ad7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The web_test checking that a SharedArrayBuffer cannot be serialized
into IndexedDB was failing because it was served inside a
non-cross-origin-isolated page, which could not create a
SharedArrayBuffer.
This CL turns that into a Web Platform Test and adds the appropriate
COOP and COEP header which make the page cross-origin-isolated,
enabling instantiation of SharedArrayBuffer.
Bug: 1194557
Change-Id: I6854a76612d237b82cb020e317459157907e77f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2846500
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Cr-Commit-Position: refs/heads/master@{#875562}