Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge xslt/ into dom/xslt/ #28639

Merged
merged 1 commit into from Apr 22, 2021
Merged

Merge xslt/ into dom/xslt/ #28639

merged 1 commit into from Apr 22, 2021

Conversation

foolip
Copy link
Member

@foolip foolip commented Apr 22, 2021

After #28638 the interface
is in dom.idl, so remove xslt.tentative.idl and move the remaining tests
into dom/xslt/ with a new README.

@foolip
Copy link
Member Author

foolip commented Apr 22, 2021

@annevk #28638 stands on its own and doesn't break tests so this can be landed separately, but I'd still like to land them in quick succession.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we move xslt/ to dom/xslt?

# NOTE: There is no standard for this API, only:
# https://wiki.whatwg.org/wiki/DOM_XSLTProcessor
# and the notes in the HTML5 spec, linked.
spec: https://html.spec.whatwg.org/multipage/scripting.html#scriptTagXSLT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still a good reference as well as it defines some things around script, no?

@foolip
Copy link
Member Author

foolip commented Apr 22, 2021

How about we move xslt/ to dom/xslt?

I considered it, there are certainly few enough tests that it would be fine to do so, but the precedent of domxpath/ and the fact that https://www.w3.org/TR/xslt/ exists made me not. But hey, let's.

@foolip foolip changed the title Remove tentative idlharness.js tests for XSLT (now in DOM) Merge xslt/ into dom/xslt/ Apr 22, 2021
Base automatically changed from actions/update-idl to master April 22, 2021 08:10
After #28638 the interface
is in dom.idl, so remove xslt.tentative.idl and move the remaining tests
into dom/xslt/ with a new README.
@foolip foolip merged commit f50fad6 into master Apr 22, 2021
@foolip foolip deleted the foolip/xpath branch April 22, 2021 08:43
foolip added a commit to foolip/wpt that referenced this pull request Feb 25, 2022
This was done in web-platform-tests#28639
but another test was added after that.
annevk pushed a commit that referenced this pull request Feb 25, 2022
This was done in #28639
but another test was added after that.
DanielRyanSmith pushed a commit to DanielRyanSmith/wpt that referenced this pull request Feb 28, 2022
This was done in web-platform-tests#28639
but another test was added after that.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 22, 2022
Automatic update from web-platform-tests
Merge xslt/ into dom/ again

This was done in web-platform-tests/wpt#28639
but another test was added after that.

--

wpt-commits: 8cc1e987f8684317655d0b1fd3f323cd59d9b073
wpt-pr: 32982
aosmond pushed a commit to aosmond/gecko that referenced this pull request Mar 26, 2022
Automatic update from web-platform-tests
Merge xslt/ into dom/ again

This was done in web-platform-tests/wpt#28639
but another test was added after that.

--

wpt-commits: 8cc1e987f8684317655d0b1fd3f323cd59d9b073
wpt-pr: 32982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants