Change to a non-fatal error for unsatisfiable image decodes. #28635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 22, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2846127
branch
from
d8f516c
to
85c1e38
Compare
|
This test is designed to tickle a now fixed crash, so I'm guessing the dev builds haven't yet picked up the bug fix to prevent the crash. |
In the event of truncated files, the spec has been changed to say we should throw a non-fatal range error instead of invalidating the image decoder. R=chcunningham Fixed: 1200137 Change-Id: I166069138f40483ca2dfe471dd9d132ae7320d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2846127 Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#875448}
jpchase
force-pushed
the
chromium-export-cl-2846127
branch
from
85c1e38
to
6f55f40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event of truncated files, the spec has been changed to say
we should throw a non-fatal range error instead of invalidating
the image decoder.
R=chcunningham
Fixed: 1200137
Change-Id: I166069138f40483ca2dfe471dd9d132ae7320d27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2846127
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#875448}