Port to CMake #14
Port to CMake #14
Conversation
|
Thank you for your PR. |
|
Update: added CMake config files so other CMake projects can find and link to this library with |
|
Last change from my side, I promise 😜 I just found out about https://api.kde.org/ecm/module/ECMGeneratePkgConfigFile.html and since we already use ECM anyway, I switched the pkgconfig file to use that rather than using |
cmake/FindQDeclarative.cmake
Outdated
| @@ -0,0 +1,40 @@ | |||
| # Try to find qdeclarative5-boostable | |||
| # Once done this will define | |||
| # QDECLARATIVE_FOUND - System has qdeclarative | |||
There was a problem hiding this comment.
QDECLARATIVE is also a bit misleading, it evokes QtDeclarative which is basically QML but what you are actually searching for is mdeclarativecache5 which is part of mapplauncherd-qt5.
MAPPLAUNCHERD_QT5_FOUND would be a better name
cmake/FindMpris.cmake
Outdated
| @@ -0,0 +1,40 @@ | |||
| # Try to find mpris | |||
There was a problem hiding this comment.
This name is a bit misleading. Strictly speaking, MPRIS is a DBus API for controlling music players https://specifications.freedesktop.org/mpris-spec/latest/ but what you are searching for here is a Qt5 wrapper around that API called QtMpris.
QTMPRIS_FOUND would be a better name
Qt is slowly deprecating QMake. They have stopped building Qt itself with QMake and moved Qt6 to CMake instead. Although QMake is still around, it's clear the focus has shifted and it would be good for applications to switch over to an alternative build system as well So hereby, switch the build system to CMake This also makes qml-asteroid available for other CMake packages as "AsteroidApp", and provides several CMake modules used to find various Mer/SailfishOS components
Qt is slowly deprecating QMake. They have stopped building Qt itself
with QMake and moved Qt6 to CMake instead. Although QMake is still
around, it's clear the focus has shifted and it would be good for
applications to switch over to an alternative build system as well
So hereby, switch the build system to CMake