[SelectMenu] Add basic support for positioning <selectmenu>'s popup. #28430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The <selectmenu>'s popup position is determined by: - vertically: where there is more space available - horizontally: if there is enough space (<selectmenu>'s width for now) or there is more space, the popup is going to be left aligned; if not it is going to be right aligned; For now, since the anchored positioning shceme is not yet provided, the position is provided by overriding the computed style for the applicable top/left/right/bottom properties. Bug: 1121840 Change-Id: I7d75e62d52595b0efa5e7295ab8f8151499c5857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2812432 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#871204}
wpt-pr-bot
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The <selectmenu>'s popup position is determined by:
or there is more space, the popup is going to be left aligned; if not
it is going to be right aligned;
For now, since the anchored positioning shceme is not yet provided,
the position is provided by overriding the computed style for
the applicable top/left/right/bottom properties.
Bug: 1121840
Change-Id: I7d75e62d52595b0efa5e7295ab8f8151499c5857
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2812432
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Reviewed-by: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#871204}