Fix e0561dbde: [MinGW] use ofstring(wchar_t*) as ofstring(wstring) doesn't exist #8985
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
OTTD2FS()
now returnsstd::wstring
on windows and MinGW fails to compile because there's nostd::ofstream(std::wstring)
constructor (but MSVC has one).For other platforms
OTTD2FS()
returnsstd::string
andstd::ofstream(std::string)
constructor exists.Description
Use
std::ofstream(wchar_t *)
constructor instead for windows, other platforms will usestd::ofstream(char *)
.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.