Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e0561dbde: [MinGW] use ofstring(wchar_t*) as ofstring(wstring) doesn't exist #8985

Merged
merged 1 commit into from Apr 10, 2021

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Apr 10, 2021

Motivation / Problem

OTTD2FS() now returns std::wstring on windows and MinGW fails to compile because there's no std::ofstream(std::wstring) constructor (but MSVC has one).
For other platforms OTTD2FS() returns std::string and std::ofstream(std::string) constructor exists.

Description

Use std::ofstream(wchar_t *) constructor instead for windows, other platforms will use std::ofstream(char *).

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro LordAro merged commit c64b094 into OpenTTD:master Apr 10, 2021
@glx22 glx22 deleted the mingw_ofstream branch April 10, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants